-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 A.M. Kuchling wrote: > * Does the patch use Durus internals correctly? In particular I > wonder about the StorageServer.page_in() method; it checks that > oid isn't on the .invalid list, but I didn't make it > check every OID in the resulting closure of references. > I suspect it should, though; am I correct? I think all objects you pass to the client MUST be verified against "invalid". In other case you risk to work with stale data, and durus code couldn't detect that. - -- Jesus Cea Avion _/_/ _/_/_/ _/_/_/ jcea@argo.es http://www.argo.es/~jcea/ _/_/ _/_/ _/_/ _/_/ _/_/ jabber / xmpp:jcea@jabber.org _/_/ _/_/ _/_/_/_/_/ _/_/ _/_/ _/_/ _/_/ _/_/ "Things are not so easy" _/_/ _/_/ _/_/ _/_/ _/_/ _/_/ "My name is Dump, Core Dump" _/_/_/ _/_/_/ _/_/ _/_/ "El amor es poner tu felicidad en la felicidad de otro" - Leibniz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iQCVAwUBRJfhsJlgi5GaxT1NAQKuxQP9EjywzT6T/ZrjggCmBsb+1IdjWT+isgnu noW4vpk+9nyuTnRFGjmIEnZV2UsM7dJmnoUMJez8wTXWFn8lAfxCqoEWNcLoxseC 0tUgnO73iUW/3iIJY8wIPZpXKlxyfytHZvnhz5DUHLX1peUzmaV3Cbekiw99Qfcq ilIaiizEi7E= =rhYd -----END PGP SIGNATURE-----