durusmail: durus-users: Closing storage engines.
Closing storage engines.
2007-03-19
2007-03-19
2007-03-19
Closing storage engines.
Peter Wilkinson
2007-03-19
Hi,
I've run across what looks like an omission to me in
storage_server.py. Currently handle_Q doesn't call close on the
storage engine and so if it needs to clean up any resources (in my
case a sqlite connection) it doesn't get a chance. I think the method
should have that additional call added and look like:

     def handle_Q(self, s):
         # graceful quit
         log(20, 'Close storage')
         self.storage.close()
         log(20, 'Quit')
         raise SystemExit

Are there any issues that I may not have thought of with adding that?

Peter Wilkinson
pw@thirdfloor.com.au



reply