durusmail: qp: deleted Permissions keys that keep coming back
deleted Permissions keys that keep coming back
2007-01-27
2007-01-27
2007-01-28
deleted Permissions keys that keep coming back
mario ruggier
2007-01-28
On Jan 27, 2007, at 9:39 PM, David Binger wrote:

> The first thing I notice here
> is your call to publisher.commit() in your handler method.
> Don't do that.  The DurusPublisher takes care of transactions
> so that you don't need to think about it.

Good that you point that out -- i was under the incorrect impression
that prior to a redirect() (the context where this code is extrapolated
from) a commit was necessitated. Looking at the DurusPublisher code
again I see that is not needed.

> You have found a bug in Permissions.ungrant() that I will correct.
> The problem is, that the ungrant() method includes the line
> del self.data[permission]
> which should be
> del self[permission].
> The difference is the second form makes the change and
> calls _p_note_change(), so that the change can be recorded
> when the next commit() is called.
>
> Please change that line in your qp.pub.users file and verify
> that the problem is corrected.

Yes, that does it, thanks.

> Good catch.
>
> _______________________________________________
> QP mailing list
> QP@mems-exchange.org
> http://mail.mems-exchange.org/mailman/listinfo/qp

reply