durusmail: quixote-users: Re: A better patch (Re: Exception-handling patch for medusa_http.py)
Exception-handling patch for medusa_http.py
2003-01-17
A better patch (Re: Exception-handling patch for medusa_http.py)
2003-01-17
A better patch (Re: Exception-handling patch for medusa_http.py)
2003-01-20
Re: A better patch (Re: Exception-handling patch for medusa_http.py)
2003-01-20
2003-01-17
Re: A better patch (Re: Exception-handling patch for medusa_http.py)
Graham Fawcett
2003-01-20
Andrew Kuchling wrote:
> On Fri, Jan 17, 2003 at 01:47:24PM -0500, Graham Fawcett wrote:
>
>>This patch catches all exceptions from the Publisher, and wraps
>>non-PublishError exceptions in a medusa_http.ServerError instance.
>
>
> Thanks for pointing out the problem, However, I think medusa_http.py
> needs to match the logic of Publisher.publish(), which calls
> finish_interrupted_request() if PublishError is raised and
> finish_failed_request() if some other exception is raised.  This
> simplifies the patch because there's no need to synthesize a
> ServerError exception to call finish_failed_request().

Ah. I hadn't understood the distinction between the two methods. Yes,
that's much better.
>
> The patch below also makes some more changes to call the publisher's
> .create_request() and .parse_request() methods, so file uploads should
> now work with the Medusa server, though I haven't tested this.

Great! I hadn't tested file-upload with medusa/Quixote but it was on my
list. I'll give it a spin tonight or tomorrow.

>
> Does the patch below work for you?  If yes, then I'll check it in.
>

The patch appears to work very well! Thanks, Andrew.

-- Graham



reply