On Sun, Jun 01, 2003 at 07:21:19PM -0500, Jason Sibre wrote:
> I think this cleans things up nicely.  cache_time now defaults to None, and
> unless I did something silly, this will produce identical behavior (with
> regard to the Expires header) to an un-patched util.py.  I also fixed that
> oversight about directories within directories (Thanks again for pointing
> that out!)
>
> As before, I have two patches to submit, one for util.py files that are
> 'stock' 0.6 release versions, which include both Graham's IMS support and my
> Expires support, and another that will patch a util.py that has already been
> patched for IMS support to include Expires support.

Hi Jason,

I think supporting the If-Modified-Since header would be a good idea.
However, we need to be careful about being compliant with the HTTP 1.1
specification.  We are probably not right now but we should be and I
don't want to make things worse.  I'm not saying there is something
specifically wrong with your patch, I'm just being cautious.

I would prefer to only support exact matches for the If-Modified-Since
header.  That makes the code simpiler and more robust.  User agents are
not supposed to mangle the Last-Modified date.  Does anyone have an
objection to only supporting exact matches?

Adding a Last-Modified header when serving static files is definitely a
good idea.  I think that should probably be enabled by default.

  Neil