durusmail: quixote-users: cgitb patch
Misc feedback
2002-01-28
2002-01-28
2002-01-29
David Ascher (2 parts)
cgitb patch
2002-01-30
2002-01-30
2002-01-30
2002-01-30
2002-01-30
2002-01-30
2002-01-30
cgitb patch
Neil Schemenauer
2002-01-30
On Wed, Jan 30, 2002 at 06:53:44PM -0500, Andrew Kuchling wrote:
> OK; is the third time the charm?

Looks good to me.  Did you update the documentation for
DISPLAY_EXCEPTIONS?

> And is there any point in keeping format_internal_error() if it just
> returns one of its parameters?

Subclasses might want to override it.  The _generate_* methods should
probably be moved to that method so that subclasses can define their own
fancy formatting if they want.

  Neil


reply