durusmail: quixote-users: Re: Patches for .7a3
Illegal Python Names cookbook recipe
2004-04-05
2004-04-05
2004-04-05
Bug fixes (was: Illegal Python Names cookbook recipe)
2004-04-07
2004-04-07
Bug fixes (was: Illegal Python Names cookbookrecipe)
2004-04-07
Patches for .7a3
2004-04-07
Re: Patches for .7a3
2004-04-08
StaticFile is broken (Quixote-0.7a3, scgi-1.2a2, Apache/1.3.27, FreeBSD 4.7)
2004-04-08
Re: Patches for .7a3
2004-04-21
2004-04-21
2004-04-06
2004-04-06
2004-04-06
2004-04-06
2004-04-06
2004-04-06
2004-04-06
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
Re: Illegal Python Names cookbook recipe
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-08
2004-04-07
2004-04-07
2004-04-07
2004-04-06
2004-04-05
2004-04-05
2004-04-05
Re: R: [Quixote-users] Illegal Python Names cookbook recipe
2004-04-06
Re: Patches for .7a3
Jason E. Sibre
2004-04-08
Hmmm....

Well, I don't see anything fishy about it.  I've removed it and confirmed
that things are slightly broken without it (for example, the component in a
_q_lookup would look like "red%20roses" instead of "red roses").

Was there something in particular about it that seemed weird to you, or just
the fact that it's there at all?

Note that Apache provides an unquoted version in the environment variables,
(which quixote.http_request.HTTPRequest pushes into "env['PATH_INFO']") but
Twisted doesn't provide an unquoted one (in it's request object), so one has
to be made in order for Qx to be able to treat them consistently and make
apps portable between web servers.  The alternative would be to require Qx
app developers to unquote the component in _q_lookups and the like.

(Likewise, Medusa provides an unquoted one, but it's being provided as the
URI, which is wrong, wrong, wrong! ( IMHO ;) )  REQUEST_URI should remain
untouched as the 'reference' of what was actually requested by the client.
This is the basis for one of the other patches I submitted, which moves
unquoting out of Medusa, and into the driver portion, so that it can be
applied to only to PATH_INFO.  This patch was one of the ones, obviously,
for which we have to wait to make sure medusa gets patched first.)

Jason

> -----Original Message-----
> From: Jason E. Sibre [mailto:jsibre@sibre.org]
> Sent: Thursday, April 08, 2004 10:28 AM
> To: Neil Schemenauer; Jason E. Sibre
> Cc: quixote-users@mems-exchange.org
> Subject: RE: [Quixote-users] Re: Patches for .7a3
>
>
> > Twisted_http:
> >
> >   HTTPS part was already in.  I added the unquoting part of the
> >   patch.  Are you sure the unquote() is correct?  It looks
> >   weird.
>
> I'll take another look at this, but I am pretty sure it's right.
> (I've been
> using it for a while, and it works, anyway.)
> Will let you know what I conclude today.
>
> Jason
>



reply