durusmail: quixote-users: Re: Patches for .7a3
Illegal Python Names cookbook recipe
2004-04-05
2004-04-05
2004-04-05
Bug fixes (was: Illegal Python Names cookbook recipe)
2004-04-07
2004-04-07
Bug fixes (was: Illegal Python Names cookbookrecipe)
2004-04-07
Patches for .7a3
2004-04-07
Re: Patches for .7a3
2004-04-08
StaticFile is broken (Quixote-0.7a3, scgi-1.2a2, Apache/1.3.27, FreeBSD 4.7)
2004-04-08
Re: Patches for .7a3
2004-04-21
2004-04-21
2004-04-06
2004-04-06
2004-04-06
2004-04-06
2004-04-06
2004-04-06
2004-04-06
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
Re: Illegal Python Names cookbook recipe
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-07
2004-04-08
2004-04-07
2004-04-07
2004-04-07
2004-04-06
2004-04-05
2004-04-05
2004-04-05
Re: R: [Quixote-users] Illegal Python Names cookbook recipe
2004-04-06
Re: Patches for .7a3
jsibre@sibre.org
2004-04-21
Quoting "A.M. Kuchling" :

> I've applied the XML-RPC patch and the multiple header patch to Medusa. A
> revised version of the Quixote portion of the multiple-header patch is
> below.

Excellent...

And good call on the modification.  Much safer for Qx users who are not riding
the upgrade train.

I'm not sure the bit about combining the headers (with ",") will work for
cookies.  Not that I take exception with what you've done.  Looks like you're
matching the RFC just right, but it makes me wonder if - by reading between the
lines in the RFC - one could infer that the Set-Cookie should only appear once
in a response.

Specifically, since the Set-Cookie values aren't encoded (or am I wrong about
this?   I'm pretty sure you don't url encode values in the http headers.), a
client would have a difficult time figuring out that this:

Set-Cookie: CUSTOMER=WILE_E_COYOTE; path=/; expires=Wednesday, 09-Nov-99
23:12:40 GMT,CUSTOMER2=ROAD_RUNNER; path=/; expires=Wednesday, 09-Nov-99
23:12:40 GMT,CUSTOMER3=Sibre,Jason; path=/; expires=Wednesday, 09-Nov-99
23:12:40 GMT

(omitting for simplicity the issue of line wrapping of HTTP headers)

would be the same as:
Set-Cookie: CUSTOMER=WILE_E_COYOTE; path=/; expires=Wednesday, 09-Nov-99
23:12:40 GMT
Set-Cookie: CUSTOMER2=ROAD_RUNNER; path=/; expires=Wednesday, 09-Nov-99 23:12:40
GMT
Set-Cookie: CUSTOMER3=Sibre,Jason; path=/; expires=Wednesday, 09-Nov-99 23:12:40
GMT

because of the ','s after the word Wednesday and my last name...

Either way, I like it.  It's an improvement for Quixote users, whether they use
the patched medusa or not.

Btw, are you going to wrap up a new dist of medusa, or shall I just get it from
CVS?


Jason









reply