durusmail: quixote-users: Re: medusa_http.py patch for basic authentication
medusa_http.py patch for basic authentication
2004-08-07
Re: medusa_http.py patch for basic authentication
2004-08-12
2004-08-20
2004-08-20
2004-08-20
2004-08-21
2004-08-24
Re: medusa_http.py patch for basic authentication
Neil Schemenauer
2004-08-19
On Wed, Aug 11, 2004 at 09:15:31PM -0400, Graham Fawcett wrote:
>         # Propagate HTTP headers - copied from twisted_http.py
>
>         for title, header in msg.items():
>             envname = title.replace('-', '_').upper()
>             if title not in ('content-type', 'content-length'):
>                 envname = "HTTP_" + envname
>             environ[envname] = header

[...]

> In re-reading this code, I'm not sure why the exception is made for
> HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH. Not a big deal, but why run
> the comparison for every header entry, just to get rid of them? Seems
> wasteful; and I'd recommend we shorten this to
>
>         for title, header in msg.items():
>             envname = title.replace('-', '_').upper()
>             envname = "HTTP_" + envname
>             environ[envname] = header
>
> in both medusa_http and twisted_http.

Has anyone tried this?  I'm wondering if this is a safe change to
make in the Quixote 1.x series.

  Neil

reply