> I haven't examined either your code or Jon's approach to this problem
> very closely.  Can you two figure out which version is better?

I think the two were pretty equivalent, really.  Hamish's would do
directory listings, which I explicitly disallowed.  I had a hook to
encapsulate the file within the whole LWN page presentation scheme.  But
the two implementations do the same basic job, and essentially in the same
way.

The "../" check is crucial, though.  Otherwise you've just exported the
world.

jon

Jonathan Corbet
Executive editor, LWN.net
corbet@lwn.net