durusmail: quixote-users: more on sessions
more on sessions
2001-10-29
2001-10-29
2001-10-29
2001-10-29
2001-10-29
more on sessions
Greg Ward
2001-10-29
On 29 October 2001, Quinn Dunkan said:
> Perhaps it should go in a seperate expire_session() method, since it's doing
> more than just revoking a cookie (and is a higher-level operation).

That sounds right -- I was going to suggest adding a 'delete' keyword
arg to revoke_session_cookie(), but your idea is much better.  Here's a
patch:

--- session.py  2001/10/29 19:34:58     1.40
+++ session.py  2001/10/29 20:02:06
@@ -245,2 +245,6 @@

+    def expire_session (self, request):
+        self.revoke_session_cookie(request)
+        del self[request.session.session_id]
+

Comments?

BTW, earlier Neil mentioned that our expire_sessions script doesn't use
del_sessions() and he would fix it.  I think del_sessions() should be
removed; it's ancient cruft that dates from the days when Quixote's
session management was my hack at adding session management to Zope.  I
think it's the last bit of cruft from those days, and I'd like to see it
gone.  Any complaints?  Neil, have you touched expire_sessions yet?
Still want to?

        Greg


reply